Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing lifecycle interfaces in Schedule component #623

Closed
cgalvarez opened this issue Jul 18, 2016 · 0 comments
Closed

Missing lifecycle interfaces in Schedule component #623

cgalvarez opened this issue Jul 18, 2016 · 0 comments
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@cgalvarez
Copy link

I think the exported class Schedule of the component primeng/schedule should implement all the interfaces of the defined lifecycle hook methods, like in exported class Calendar of the component primeng/calendar.

I don't know if this leads to any error. As far as I've been playing with the component it appears to work fine, but I think it should be export class Schedule implements AfterViewInit, OnDestroy, DoCheck {. Maybe I'm wrong... I'm pretty newbie to Angular2.

@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Jul 23, 2016
@cagataycivici cagataycivici added this to the 1.0.0-beta.11 milestone Jul 23, 2016
@cagataycivici cagataycivici self-assigned this Jul 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

2 participants