Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement restore of appendTo logic of overlays #6286

Closed
cagataycivici opened this issue Aug 10, 2018 · 0 comments
Closed

Reimplement restore of appendTo logic of overlays #6286

cagataycivici opened this issue Aug 10, 2018 · 0 comments
Assignees
@cagataycivici
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
6.1.1

Comments

@cagataycivici
Copy link
Member

cagataycivici commented Aug 10, 2018 •
edited
Loading

Currently to void animation of overlays, call ngDestroy where overlay is appended to its original location when appendTo is defined like appendTo="body", however this should be only done at ngOnDestory not on overlay close.
@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Aug 10, 2018
@cagataycivici cagataycivici added this to the 6.1.1 milestone Aug 10, 2018
@cagataycivici cagataycivici self-assigned this Aug 10, 2018
@cagataycivici cagataycivici removed this from the 6.1.1 milestone Aug 10, 2018
@cagataycivici cagataycivici changed the title Remove restore of appendTo logic of overlays Reimplement restore of appendTo logic of overlays Aug 10, 2018
@cagataycivici cagataycivici added this to the 6.1.1 milestone Aug 10, 2018
@cagataycivici cagataycivici reopened this Aug 10, 2018
This was referenced Aug 10, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagataycivici cagataycivici

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
6.1.1
Development

No branches or pull requests
1 participant
@cagataycivici