Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfirmDialog screen position not working properly #6342

Closed
cleitondutra opened this issue Aug 16, 2018 · 1 comment
Closed

ConfirmDialog screen position not working properly #6342

cleitondutra opened this issue Aug 16, 2018 · 1 comment
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@cleitondutra
Copy link

cleitondutra commented Aug 16, 2018

[X] bug report

Current behavior

Go to a page that has scroll, open the confirmDialog, example in attached image.

Expected behavior

After running confirmDialog the page position (that is in the background) should not go to the top of the page. The position of the screen should remain in the same position when the dialog was opened.

Minimal reproduction of the problem with instructions
Image

primedialog

  • Angular version: 6.X

  • PrimeNG version: 6.1.2

  • Browser: [all]

  • Language: [all]
@cagataycivici cagataycivici self-assigned this Aug 29, 2018
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Aug 29, 2018
@cagataycivici cagataycivici added this to the 6.1.3 milestone Aug 29, 2018
@cagataycivici
Copy link
Member

This is a regression caused by trying to support iOS block scroll, more info at;

https://medium.com/jsdownunder/locking-body-scroll-for-all-devices-22def9615177

I'll just revert it as it causes more problems and keep iOS issue as open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants