Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Spinner #6496

Closed
cagataycivici opened this issue Sep 13, 2018 · 1 comment
Closed

Rewrite Spinner #6496

cagataycivici opened this issue Sep 13, 2018 · 1 comment
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@cagataycivici
Copy link
Member

Current implementation is not aligned with PrimeFaces and PrimeReact, align the component behavior with the other two which uses blur event to parse the value from string to a number, current spinner does on it on keyup which causes various issues like 5490.

@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Sep 13, 2018
@cagataycivici cagataycivici added this to the 6.1.4 milestone Sep 13, 2018
@cagataycivici cagataycivici self-assigned this Sep 13, 2018
@dkrysiak
Copy link

dkrysiak commented Nov 9, 2018

Hmmm. This change is backward incompatible as it removes thousandSeparator and decimalSeparator (which were actually the only features why I have used this component).

Also, documentation hasn't been changed to reflect these changes – it still contains thousandSeparator and decimalSeparator in the list of properties, without any note about them being not supported anymore
https://www.primefaces.org/primeng/#/spinner

IMO changes like this should be made in major versions only. Also there should be some information about backward incompatible changes like this in the official announcemenent or changelog. Information about this change isn't even googleable :(

Do not like it :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

2 participants