Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aria properties for AutoComplete #6565

Closed
mattcfilbert opened this issue Sep 25, 2018 · 0 comments
Closed

Aria properties for AutoComplete #6565

mattcfilbert opened this issue Sep 25, 2018 · 0 comments
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@mattcfilbert
Copy link
Contributor

I'm submitting a ...

[ ] bug report => Search github for a similar issue or PR before submitting
[X] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior
Many input components (including autocomplete) can be made more accessible to the visually impaired by adding "aria-label" and "aria-required" attributes. The "required" attribute does a lot of what the "aria-required" attribute does, but the latter is still useful for user agents that do not yet support HTML5.

Proposed improvement
I am submitting a PR that adds "aria-label" and "aria-required" attributes to the autocomplete component.

What is the motivation / use case for changing the behavior?
This PR will improve PrimeNG's accessibility for visually impaired users who rely on screen readers.

NOTE: This issue is based on #6103, but focused on a specific component.

@cagataycivici cagataycivici self-assigned this Oct 11, 2018
@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Oct 11, 2018
@cagataycivici cagataycivici added this to the 6.1.5 milestone Oct 11, 2018
@cagataycivici cagataycivici changed the title Improving Accessibility for Autocomplete aria properties for AutoComplete Oct 12, 2018
@cagataycivici cagataycivici changed the title aria properties for AutoComplete Aria properties for AutoComplete Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

2 participants