Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

columnSource is never subscribed because frozen is always undefined #6569

Closed
mronus opened this issue Sep 26, 2018 · 2 comments
Closed

columnSource is never subscribed because frozen is always undefined #6569

mronus opened this issue Sep 26, 2018 · 2 comments

Comments

@mronus
Copy link

mronus commented Sep 26, 2018

I'm submitting a ... (check one with "x")

[ x ] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior
ScrollableView#setScrollHeight is never triggered after any change in columns because frozen is alwasy undefined in the constructor. So I think the following if block must be moved to ngAfterViewInit.

  • I think it would be really good to have it called after not only change in columns but also any column size change.

if (this.frozen) {

Expected behavior
ScrollableView#setScrollHeight should be triggered after any change in columns and their sizes.

What is the motivation / use case for changing the behavior?
In case you have resizable columns + some frozen columns, the height of ui-table-scrollable-body is not re-calculated after a column size change that makes the grid scrollable horizontally.

  • Angular version: 6.1.7

  • PrimeNG version: 6.1.3

@JacobSiegle
Copy link
Contributor

Put a PR in for this earlier - #6608.

@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Sep 5, 2019
@cagataycivici cagataycivici added this to the 8.1.0 milestone Sep 5, 2019
@cagataycivici cagataycivici added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add labels Sep 5, 2019
@yigitfindikli yigitfindikli removed the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Sep 6, 2019
@yigitfindikli yigitfindikli removed their assignment Sep 6, 2019
@yigitfindikli yigitfindikli removed this from the 8.1.0 milestone Sep 6, 2019
@yigitfindikli
Copy link
Contributor

fixed in cdd333b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants