Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty tooltips are still displayed #705

Closed
mmikeyy opened this issue Aug 7, 2016 · 1 comment
Closed

Empty tooltips are still displayed #705

mmikeyy opened this issue Aug 7, 2016 · 1 comment
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@mmikeyy
Copy link
Contributor

mmikeyy commented Aug 7, 2016

I have conditional tooltips (some elements generated by a *ngFor loop need them, others do not).

I tried assigning empty text or null value to the tooltip for items not requiring one. The arrow and a small empty container are still rendered.

I just added these few lines to the tooltip.js code and the problem is solved:

 Tooltip.prototype.show = function () {
        if (!this.text){              // start
            return
        }                             //end
        this.create();

This would be a minor but welcome enhancement to the component.

@dzhavat
Copy link
Contributor

dzhavat commented Nov 18, 2016

Fixed in #1361

@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Nov 21, 2016
@cagataycivici cagataycivici modified the milestone: 1.0.0-RC6 Nov 21, 2016
@cagataycivici cagataycivici self-assigned this Nov 21, 2016
@cagataycivici cagataycivici added this to the 1.0.0 milestone Nov 21, 2016
@cagataycivici cagataycivici changed the title inelegant tooltip rendering when no tooltip needed Empty tooltips are still displayed Nov 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants