Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple selection fails on windows for Tree and TreeTable #720

Closed
mmikeyy opened this issue Aug 9, 2016 · 0 comments
Closed

Multiple selection fails on windows for Tree and TreeTable #720

mmikeyy opened this issue Aug 9, 2016 · 0 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@mmikeyy
Copy link
Contributor

mmikeyy commented Aug 9, 2016

the reason is that on line 47 of treetable.js, which follows:

this.selection = (!event.metaKey) ? [] : this.selection || [];

it is the variable metaKey, not event.metaKey that should be tested.

Multiple row selection works when line 47 is changed to

this.selection = (!metaKey) ? [] : this.selection || [];
@cagataycivici cagataycivici changed the title multiple row selection not possible in tableTree Multiple selection fails on windows for Tree and TreeTable Oct 1, 2016
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Oct 1, 2016
@cagataycivici cagataycivici added this to the 1.0.0-beta.17 milestone Oct 1, 2016
@cagataycivici cagataycivici self-assigned this Oct 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants