Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with indexing of current page in currentPageReport #7684

Closed
BogdanMaier opened this issue May 14, 2019 · 1 comment
Closed

Issue with indexing of current page in currentPageReport #7684

BogdanMaier opened this issue May 14, 2019 · 1 comment
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@BogdanMaier
Copy link
Contributor

BogdanMaier commented May 14, 2019

I'm submitting a ...

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
https://github-47e8gw.stackblitz.io

Current behavior
When displaying the pageReport the current page index is 0 based.

Expected behavior
My suggestion is to use 1 based indexing for the current page value.

Minimal reproduction of the problem with instructions
https://github-47e8gw.stackblitz.io

What is the motivation / use case for changing the behavior?
I want to use the pagination report. This happens for independently defined paginator and included paginators aswell.

Please tell us about your environment:

  • Angular version: 8.0.0-beta.12

  • PrimeNG version: 7.1.2

  • Browser: [all]

  • Language: [all]

@BogdanMaier
Copy link
Contributor Author

Fixing PR: #7685

@cagataycivici cagataycivici self-assigned this Jun 3, 2019
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Jun 3, 2019
@cagataycivici cagataycivici added this to the 8.0.0-rc.1 milestone Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants