Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-treetable not filtering when only one parent is present #7757

Closed
jorgefgm opened this issue May 31, 2019 · 3 comments
Closed

p-treetable not filtering when only one parent is present #7757

jorgefgm opened this issue May 31, 2019 · 3 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@jorgefgm
Copy link

If you have a PrimeNG PRO Support subscription please post your issue at;

https://pro.primefaces.org

where our team will respond within 4 business hours.

If you do not have a PrimeNG PRO Support subscription, fill-in the report below. Please note that
your issue will be added to the waiting list of community issues and will be reviewed on a first-come first-serve basis, as a result, the support team is unable to guarantee a specific schedule on when it will be reviewed. Thank you for your understanding.

Current Waiting Time: ~8 weeks.

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[x] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior
p-treetable filter option doesn't work when you only have one parent, it doesn't filter through the childs

Expected behavior
Filter data even when you only have one parent.

Minimal reproduction of the problem with instructions
https://stackblitz.com/edit/github-3dtpnj

What is the motivation / use case for changing the behavior?
Missing functionality

Please tell us about your environment:

  • Angular version: 7.2.9
  • PrimeNG version: 7.1.3
  • Browser: all
@mertsincan mertsincan self-assigned this Jun 17, 2019
@mertsincan mertsincan added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Jun 17, 2019
@mertsincan mertsincan added this to the 8.0.1 milestone Jun 17, 2019
@mertsincan
Copy link
Member

Hi @Gretam11,

Thanks a lot for the PR! Unfortunately, your fix does not work in some cases. Could you please try my fix?

Thanks again.

@Gretam11
Copy link
Contributor

Hi @mertsincan,
I've checked new version and it works well there, thank you for fixing it!
I will close my PR then.

@mertsincan
Copy link
Member

Glad to hear, thanks a lot for the update!

Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

4 participants