Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing times between 12:00AM-12:59AM save as PM #7977

Closed
sabrina-stangler opened this issue Jul 22, 2019 · 2 comments
Closed

Typing times between 12:00AM-12:59AM save as PM #7977

sabrina-stangler opened this issue Jul 22, 2019 · 2 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@sabrina-stangler
Copy link

sabrina-stangler commented Jul 22, 2019

I'm submitting a ...

[X] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior
When using a p-calendar with both a date & time selector with text entry enabled & 12hr format used, using the text input to select a time between 12:00AM - 12:59AM is switched to PM on blur of the field.

Expected behavior
The time's morning/afternoon indicator (AM/PM) should be maintained.

One of my colleagues made a fix in this PR: RLijewski@d76d575

Minimal reproduction of the problem with instructions

  1. Open calendar date & time chooser
  2. In the text input field, type in any date with a time of 12:00 AM
  3. Select away from the field

What is the motivation / use case for changing the behavior?
So that we can default a date to have a time of midnight that day if a time is not identified by the user

Please tell us about your environment:
Windows, IntelliJ, HTTP, p-calendar is in a drawer and within a form

  • Angular version: 6.0

  • PrimeNG version: 6.1

  • Browser: [ Chrome 75 ]

  • Language: [ TypeScript 3.2.4 ]

  • Node (for AoT issues): node --version =

@cagataycivici cagataycivici added this to the 8.0.3 milestone Jul 24, 2019
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Jul 24, 2019
@RLijewski
Copy link

PR here - #7960

@cagataycivici
Copy link
Member

PR merged, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

4 participants