Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collision detection for tooltip positioning to keep inside viewport #812

Closed
mdonato7 opened this issue Aug 30, 2016 · 3 comments
Closed

Collision detection for tooltip positioning to keep inside viewport #812

mdonato7 opened this issue Aug 30, 2016 · 3 comments
Assignees
@Mrtcndkn
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
4.1.RC1

Comments

@mdonato7
Copy link

To reproduce place an element near the left or right edge of the screen and set the pTooltip attribute to a long text value with tooltipPosition = "top" or "bottom". The tooltip flows off the edge of the screen.
@cagataycivici cagataycivici changed the title Long tooltips render off screen Collision detection for toolitp positioning to keep inside viewport May 29, 2017
@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label May 29, 2017
@cagataycivici
Copy link
Member

Yes, we should add collision detection.

@Mrtcndkn Mrtcndkn self-assigned this Jun 5, 2017
@Mrtcndkn Mrtcndkn added this to the 4.1.RC1 milestone Jun 5, 2017
@cagataycivici cagataycivici added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Jun 6, 2017
@cagataycivici
Copy link
Member

Reopening for code review.

@cagataycivici cagataycivici reopened this Jun 6, 2017
@cagataycivici cagataycivici changed the title Collision detection for toolitp positioning to keep inside viewport Collision detection for tooltip positioning to keep inside viewport Jun 6, 2017
@cagataycivici cagataycivici removed the Status: Pending Review Issue or pull request is being reviewed by Core Team label Jun 8, 2017
@cagataycivici
Copy link
Member

Complete rewrite.

@cagataycivici cagataycivici mentioned this issue Jun 8, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mrtcndkn Mrtcndkn

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
4.1.RC1
Development

No branches or pull requests
3 participants
@cagataycivici @mdonato7 @Mrtcndkn