Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toast blocks protractor #8122

Closed
yelhouti opened this issue Sep 5, 2019 · 1 comment
Closed

Toast blocks protractor #8122

yelhouti opened this issue Sep 5, 2019 · 1 comment
Assignees
@yigitfindikli
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
9.0.6

Comments

@yelhouti
Copy link
Contributor

yelhouti commented Sep 5, 2019

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior

Toast uses setTimeout blocking protractor test framework

Expected behavior

Toasts should not block protractor.

This bug #4681 had been fixed for growl using this PR: 26506f9

And could be fixed the exact same way
@cagataycivici cagataycivici added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Mar 29, 2020
@cagataycivici cagataycivici added this to the 9.0.4 milestone Mar 29, 2020
@cagataycivici cagataycivici self-assigned this Mar 29, 2020
@cagataycivici cagataycivici changed the title Bug reintroduced in Toast blocking protractor Toast blocks protractor Mar 29, 2020
@cagataycivici
Copy link
Member

Review for 9.0.4

@yigitfindikli yigitfindikli added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yigitfindikli yigitfindikli

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
9.0.6
Development

No branches or pull requests
3 participants
@cagataycivici @yelhouti @yigitfindikli