Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfirmDialog on close should act as reject #921

Closed
moxival opened this issue Sep 19, 2016 · 2 comments
Closed

ConfirmDialog on close should act as reject #921

moxival opened this issue Sep 19, 2016 · 2 comments
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@moxival
Copy link
Contributor

moxival commented Sep 19, 2016

When closing a confirmation dialog (via close button or ESC) i think that it should act as if the cancel button was clicked.

@cagataycivici cagataycivici self-assigned this May 31, 2017
@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label May 31, 2017
@cagataycivici cagataycivici added this to the 4.0.4 milestone May 31, 2017
@ova2
Copy link

ova2 commented Jun 10, 2017

Solution is here #2757

@QuentinLeGoff
Copy link

I think the escape button and the reject button should not have the same behavior because to click on the 'No' button means reject the action however escape the dialog means go back to the previous state.

So the escape button should not start the reject method. No ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

4 participants