Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort event should not be triggered if target is clickable #963

Closed
tamatcho opened this issue Sep 26, 2016 · 4 comments
Closed

Sort event should not be triggered if target is clickable #963

tamatcho opened this issue Sep 26, 2016 · 4 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@tamatcho
Copy link

Hi,
I have a MultiSelect as template in a datable column header and the column is also sortable,but when clicking to drop down the menu it also sorts the table. Is there a way to separate both use cases?

@lbamburski
Copy link
Contributor

adding (click)="onFilterInputClick($event)" on MultiSelect or regular select prevents sorting.

@tamatcho
Copy link
Author

thanks for the advice but it still not working, I'm getting the exception 'self.context.onFilterInputClick' is undefined as shown in the attached screenshot.
screen shot 2016-09-26 at 15 58 35

@lbamburski
Copy link
Contributor

I was editing Datatable template and put that click event there. Outside of datatable that method doesn't exist.

@cagataycivici cagataycivici added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Sep 27, 2016
@cagataycivici cagataycivici added this to the 1.0.0-beta.17 milestone Sep 27, 2016
@cagataycivici cagataycivici self-assigned this Sep 27, 2016
@cagataycivici
Copy link
Member

This should also happen when you add an input or button or anchor inside table header. We need to find a way to stop sorting in these cases.

@cagataycivici cagataycivici added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Sep 27, 2016
@cagataycivici cagataycivici changed the title MultiSelect templated in sortable datable column header: sort when i click to drop down the menu Sort event should not be triggered if target is clickable Sep 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants