Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Row click event should not be triggered if target is clickable #971

Closed
ribizli opened this issue Sep 27, 2016 · 5 comments
Closed

Row click event should not be triggered if target is clickable #971

ribizli opened this issue Sep 27, 2016 · 5 comments
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@ribizli
Copy link

ribizli commented Sep 27, 2016

No description provided.

@cagataycivici
Copy link
Member

I'm not sure, technically row is clicked due to propagation right? What if another user wants it to be fired?

@ribizli
Copy link
Author

ribizli commented Sep 27, 2016

I have the following usecase: multi select with checkboxes and default action on row click, The action opens the record in a new route. So it is not possible to do selection on the table because we navigate away.

@cagataycivici
Copy link
Member

cagataycivici commented Sep 27, 2016

I think we do not select row (onRowSelect) in such a case when selection mode is on, it makes sense to do it for onRowClick callback as well.

Do you use p:checkbox?

@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Sep 27, 2016
@cagataycivici cagataycivici added this to the 1.0.0-beta.17 milestone Sep 27, 2016
@cagataycivici cagataycivici self-assigned this Sep 27, 2016
@ribizli
Copy link
Author

ribizli commented Sep 27, 2016

Yes, as stated in the title... If selectionMode is defined on the table (not on column) my usecase makes no sense.

@cagataycivici cagataycivici changed the title DataTable: onRowClick should not be fired when selection checkbox/radio is clicked Row click event should not be triggered if target is clickable Sep 27, 2016
@cagataycivici
Copy link
Member

I've applied the similar solution we had in PrimeFaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

2 participants