Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfirmDialog component dysfunction #998

Closed
cholokla opened this issue Sep 30, 2016 · 2 comments
Closed

ConfirmDialog component dysfunction #998

cholokla opened this issue Sep 30, 2016 · 2 comments

Comments

@cholokla
Copy link

I have two problems with ConfirmDialog component and Angular 2.0.1.

Firstly, 'rejectIcon' attribute doesn't seem to set icon while 'acceptIcon' is working properly.

Second and more problematic is when I try to use 'confirmationService.confirm' method several times in a row passing different 'message' attributes. It looks like only the first one is set in the dialog, and next calls are still showing the same message.

And one question, could it be possible to not fix the default width od the dialog (if not set manualy using the 'width' attribute)? In such case text areas shoud be set to css no-wrap and in result dialog width will follow text width.

@kt215
Copy link
Contributor

kt215 commented Oct 1, 2016

It looks like first and second issues will be fixed in 1.0.0-beta.17 by #946 and #958, respectively.

@cholokla
Copy link
Author

cholokla commented Oct 4, 2016

yes, it works now like a charm :)

only dialog width suggestion left to consider...

@cholokla cholokla closed this as completed Oct 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants