Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PanelMenu Icon does not show for entries without sub children #1121

Closed
Rainson12 opened this issue Dec 11, 2019 · 0 comments
Closed

PanelMenu Icon does not show for entries without sub children #1121

Rainson12 opened this issue Dec 11, 2019 · 0 comments
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@Rainson12
Copy link

Rainson12 commented Dec 11, 2019

I'm submitting a ... (check one with "x")

[X ] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Codesandbox Case (Bug Reports)
https://codesandbox.io/s/primereact-test-vsh6z

Current behavior
When setting the icon property for a menu entry the icon is only being rendered if the menu has subitems. That doesnt make real sense to me and should not be the excpected behavior. You can see the behavior in the codesandbox example for the "File" menu entry.

Expected behavior
Show the menu icon regardless whether the menu entry has childrens or not.

Minimal reproduction of the problem with instructions
Use PanelMenu Component and set the icon property while not setting the items property

Please tell us about your environment:
Tested with Unix/Windows environments

  • React version:
    16.12.0

  • PrimeReact version:
    3.3.3

  • Browser: [all]

  • Language: [all]

@mertsincan mertsincan self-assigned this Jan 17, 2020
@mertsincan mertsincan added the Type: Bug Issue contains a defect related to a specific component. label Jan 17, 2020
@mertsincan mertsincan removed their assignment Jan 17, 2020
@mertsincan mertsincan added this to the 3.4.0 milestone Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

No branches or pull requests

2 participants