Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataView: lazy loading implementation #1264

Closed
PaulInglis opened this issue Mar 12, 2020 · 3 comments
Closed

DataView: lazy loading implementation #1264

PaulInglis opened this issue Mar 12, 2020 · 3 comments
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@PaulInglis
Copy link
Contributor

PaulInglis commented Mar 12, 2020

I'm submitting a ... (check one with "x")

[ ] bug report
[X] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Current behavior

Lazy loading on DataTable has the ability to load pages of data and each time the page changes a loading flag can be set and an internal "loading" overlay and icon is set.
This is not implemented on DataView, despite documentation stating "Refer to DataTable lazy loading for a sample implementation"

Expected behavior

Be able to set a "loading" prop which displays the internal loading overlay

Minimal reproduction of the problem with instructions

Please tell us about your environment:

  • React version:
  • PrimeReact version:

4.1.0

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

All

  • Language: [all | TypeScript X.X | ES6/7 | ES5]
    Typescript
@cagataycivici
Copy link
Member

Is it the lazy loading implementation or the lack of loading prop? I see that there is a lazy prop in DataView as well. I'll add a sample to next week's 4.1.2 like the in memory sample of DataTable to provide an example.

Also for Table, we'll add a demo with node.js and a real datasource like mysql to demonstrate lazy page-sort-filter.

@cagataycivici cagataycivici self-assigned this Mar 14, 2020
@cagataycivici cagataycivici added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Mar 14, 2020
@cagataycivici cagataycivici added this to the 4.1.2 milestone Mar 14, 2020
@PaulInglis
Copy link
Contributor Author

@cagataycivici both really. There is no loading prop and there is no implementation of the internal overlay and chosen icon (or component would be nice)
As far as I can tell, it deals with the pagination ok via the event, but no way to visually indicate that something is happening

@cagataycivici
Copy link
Member

@mertsincan is on it for 4.1.2, thanks.

@cagataycivici cagataycivici added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

3 participants