Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add template property support to MenuModel API in all menu components #1635

Closed
NathanPB opened this issue Oct 14, 2020 · 2 comments
Closed
Assignees
Labels
Type: New Feature Issue contains a new feature or new component request
Milestone

Comments

@NathanPB
Copy link
Contributor

I'm submitting a ... (check one with "x")

[ ] bug report
[ x ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

It was supposed to be added in #1597, right? I had tons of problems on using this new feature in TieredMenus, so I went to look at the source and it was implemented only to work in SplitButtons. Is this meant to be that way? Why? This does not makes sense if so

Works:

<SplitButton model={[ {template: <span>foobar</span>} ]}>

Does not works:

<TieredMenu model={[ {template: <span>foobar</span>} ]}>
@NathanPB
Copy link
Contributor Author

I found a workaround of passing JSX elements to the label property

@mertsincan mertsincan self-assigned this Jan 26, 2021
@mertsincan mertsincan changed the title Add template property support to MenuModel API in the other menus too Add template property support to MenuModel API in all menu components Jan 26, 2021
@mertsincan mertsincan added the Type: New Feature Issue contains a new feature or new component request label Jan 26, 2021
@mertsincan mertsincan added this to the 6.0.1 milestone Jan 26, 2021
@mertsincan
Copy link
Member

Hi @NathanPB,

Please see this issue; #1783 The template option is more customizable.

Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Development

No branches or pull requests

2 participants