Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SlideMenu menu model template has wrong classname #1894

Closed
matthewmartinspok opened this issue Mar 23, 2021 · 1 comment
Closed

SlideMenu menu model template has wrong classname #1894

matthewmartinspok opened this issue Mar 23, 2021 · 1 comment
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@matthewmartinspok
Copy link

I'm submitting a ... (check one with "x")

[ x ] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Current behavior
When working with the menu model for the SlideMenu, the options.className is set to p-menuitem. This causes issues with the default styling of the component(p-menuitem-link styles do not get applied at all).

Expected behavior
When working with the menu model for the SlideMenu, the options.className should be set to p-menuitem-link. This is how the rest of the menu components work and would allow for easy passthrough when creating your own template items.

Minimal reproduction of the problem with instructions
Create a template for the SlideMenu model items. Grab the className from the options. The className is set to p-menuitem which causes weird styling issues and the SlideMenu will not look right. This should be p-menuitem-link like the rest of the Menu components have the className correctly set to when working with the menu model.

Please tell us about your environment:
Windows, VSCode, Chrome

  • React version:
    ^17.0.1, ^16.8.0

  • PrimeReact version:
    ^6.2.1

  • Browser: [all]

  • Language: [all]

@mertsincan mertsincan self-assigned this Apr 20, 2021
@mertsincan mertsincan added the Type: Bug Issue contains a defect related to a specific component. label Apr 20, 2021
@mertsincan mertsincan added this to the 6.3.0 milestone Apr 20, 2021
@mertsincan
Copy link
Member

Hi,

Thanks a lot for the report!

Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

No branches or pull requests

2 participants