Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Sidebar Close button ripple effect on opposite side rather than on the button #2185

Closed
Royal-lobster opened this issue Jul 12, 2021 · 1 comment
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@Royal-lobster
Copy link

Royal-lobster commented Jul 12, 2021

[x ] bug report
[ ] feature request
[ ] support request

Current behavior

Sidebar close button ripple effect is on opposite side of sidebar. This behavior is more noticeable on dark themes. (Ripple is not visible but still present in light theme)

sidemenu.bug.reactprime.mp4

Expected behavior

Ripple effect should actually align with close button

Steps to Reproduce

can be clearly seen with in documentation/demo website (Visible clearly with any dark theme)
https://www.primefaces.org/primereact/showcase/#/sidebar

More Details

  • PrimeReact version: All Versions that support ripple effect
  • Browser: All (Seen in Firefox, Edge and Chrome)
  • Language: All (Seen in JavaScript and Typescript Environment)
  • Operating System: (Seen in Windows and Linux)
@mertsincan mertsincan self-assigned this Jul 14, 2021
@mertsincan mertsincan added the Type: Bug Issue contains a defect related to a specific component. label Jul 14, 2021
@mertsincan mertsincan added this to the 6.5.0 milestone Jul 14, 2021
@mertsincan
Copy link
Member

Good catch! Thanks a lot for your report! Fixed now.

Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

No branches or pull requests

2 participants