Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataTable] Row expander customization isn't working #2487

Closed
CezarCretu opened this issue Dec 2, 2021 · 1 comment
Closed

[DataTable] Row expander customization isn't working #2487

CezarCretu opened this issue Dec 2, 2021 · 1 comment
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@CezarCretu
Copy link

I'm submitting a ... (check one with "x")

[x] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Codesandbox Case (Bug Reports)

https://codesandbox.io/embed/primereact-test-forked-vpi8i

Current behavior
A column with expander={true} and a body func does not receive the expander object on its column properties.

<Column expander body={(row, colProps) => console.log(colProps.expander)} /> //undefined

Expected behavior
According to #1762 it should receive those props for easy customization of the expander button.
Instead, when a body function is defined, the branch handling the expander is short-circuited here.

Minimal reproduction of the problem with instructions

Please tell us about your environment:

  • PrimeReact version: 7.01.
@melloware
Copy link
Member

Can you provide a PR fixing the issue since you have identified it?

@mertsincan mertsincan self-assigned this Dec 13, 2021
@mertsincan mertsincan added the Type: Bug Issue contains a defect related to a specific component. label Dec 13, 2021
@mertsincan mertsincan added this to the 8.0.0 milestone Dec 13, 2021
@mertsincan mertsincan modified the milestones: 8.0.0, 7.1.0 Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

No branches or pull requests

3 participants