Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug on Dark Themes related with fixed columns #2630

Closed
wolnynick opened this issue Feb 4, 2022 · 2 comments
Closed

Bug on Dark Themes related with fixed columns #2630

wolnynick opened this issue Feb 4, 2022 · 2 comments
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@wolnynick
Copy link

[X] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Current behavior
On Vela-Blue theme there is a error with fixed columns, because background color on stripped rows and also on hover have opacity and because of it we can see values from not fixed columns under fixed columns after scroll

Before scroll:

image

After scroll:

image

Classes responsible for this bug:

.p-datatable.p-datatable-striped .p-datatable-tbody > tr.p-row-odd {
    background: rgba(255, 255, 255, 0.01);
}
.p-datatable.p-datatable-hoverable-rows .p-datatable-tbody > tr:not(.p-highlight):not(.p-datatable-emptymessage):hover {
    background: rgba(255, 255, 255, 0.03);
    color: rgba(255, 255, 255, 0.87);
}

React version:
17.0.2

PrimeReact version:
7.2.0

@melloware
Copy link
Member

I can't imagine its just vela-blue i would assume all the themes have this problem?

@wolnynick
Copy link
Author

wolnynick commented Feb 4, 2022

I don't know how many, I use only Saga-Blue and Vela-Blue and on Saga-Blue I don't have any problems because in this theme there is no opacity in these classes:

.p-datatable.p-datatable-striped .p-datatable-tbody > tr.p-row-odd {
    background: #fcfcfc;
}
.p-datatable.p-datatable-hoverable-rows .p-datatable-tbody > tr:not(.p-highlight):not(.p-datatable-emptymessage):hover {
    background: #e9ecef;
    color: #495057;
}

@yigitfindikli yigitfindikli added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Feb 10, 2022
@yigitfindikli yigitfindikli modified the milestones: 7.2.1, Future Feb 10, 2022
@yigitfindikli yigitfindikli changed the title Bug on Vela-Blue theme related with fixed columns Bug on Dark Themes related with fixed columns Feb 18, 2022
@yigitfindikli yigitfindikli modified the milestones: Future, 7.2.1 Feb 18, 2022
@yigitfindikli yigitfindikli added Type: Bug Issue contains a defect related to a specific component. and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

No branches or pull requests

4 participants