Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputTextarea in 8.5.0 doesn't work with typescript #3283

Closed
Strandedpirate opened this issue Sep 10, 2022 · 1 comment
Closed

InputTextarea in 8.5.0 doesn't work with typescript #3283

Strandedpirate opened this issue Sep 10, 2022 · 1 comment
Assignees
Labels
Resolution: Duplicate Issue has already been reported or a pull request related to same issue has already been submitted

Comments

@Strandedpirate
Copy link

Describe the bug

The InputTextarea is getting flagged by typescript on the rows property. CRA with plain-old-javascript doesn't have this problem, but CRA w/Typescript does.

Fresh react-create-app with the typescript template:
image

yarn dev
image

Reproducer

No response

PrimeReact version

8.5.0

React version

18.x

Language

ES6

Build / Runtime

Create React App (CRA)

Browser(s)

ALL

Steps to reproduce the behavior

  1. npx create-react-app primereact-test-typescript --template typescript
  2. cd primereact-test-typescript
  3. yarn add primereact
import { InputTextarea } from 'primereact/inputtextarea'
import { useState } from 'react'
...

  const [note, setNote] = useState('hello');
...
  <InputTextarea
    style={{ height: '100%' }}
    rows={5}
    cols={60}
    value={note}
    onChange={(e) => setNote(e.target.value)}
          />

Expected behavior

No error during build or runtime

@Strandedpirate Strandedpirate added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 10, 2022
@melloware melloware added Resolution: Duplicate Issue has already been reported or a pull request related to same issue has already been submitted and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 10, 2022
@melloware melloware self-assigned this Sep 10, 2022
@melloware melloware added this to the 8.6.0 milestone Sep 10, 2022
@melloware
Copy link
Member

Duplicate of #3252 already fixed

@mertsincan mertsincan removed this from the 8.6.0 milestone Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Duplicate Issue has already been reported or a pull request related to same issue has already been submitted
Projects
None yet
Development

No branches or pull requests

3 participants