Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree doesn't update on external change #372

Closed
eladbs opened this issue Apr 4, 2018 · 3 comments
Closed

Tree doesn't update on external change #372

eladbs opened this issue Apr 4, 2018 · 3 comments
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@eladbs
Copy link

eladbs commented Apr 4, 2018

Hi,

First, many thanks for this great component suite!
I use the tree component to view hierarchy data. I have a filter that changes the tree structure that is passed to the Tree component but the tree doesn't update.
I created a much simpler example which is self explained.

Please have a look and let me know if I missed something or is this actually a bug.

Thanks!!

I'm submitting a ... (check one with "x")

[X ] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=57

Plunkr Case (Bug Reports)
https://plnkr.co/edit/l1Q7PHIcuXplxKwjZ1V0

Current behavior
Tree component doesn't render external updates to tree data.
Example: A button to change the "expanded" value of the root element. Click on the button to expand/collapse the tree doesn't work.

Expected behavior
Tree should re-render the tree structure on external updates.

Minimal reproduction of the problem with instructions
Look at Plunkr above.

@eladbs
Copy link
Author

eladbs commented Apr 4, 2018

Aaaannndddd.... Now I found that there is a PR that should fix this:
#297

I would appreciate if you could approve the PR.
Thanks!

@mertsincan mertsincan self-assigned this Apr 6, 2018
@mertsincan mertsincan added the Type: Bug Issue contains a defect related to a specific component. label Apr 6, 2018
@mertsincan mertsincan added this to the 1.5.1 milestone Apr 6, 2018
@mertsincan
Copy link
Member

I'll review PR #297 and get back to you.

@eladbs
Copy link
Author

eladbs commented Apr 6, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

No branches or pull requests

2 participants