Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maximizable Dialog #453

Closed
cagataycivici opened this issue Jun 25, 2018 · 1 comment
Closed

Maximizable Dialog #453

cagataycivici opened this issue Jun 25, 2018 · 1 comment
Assignees
@cagataycivici
Labels
Type: New Feature Issue contains a new feature or new component request
Milestone
2.0.0-alpha.1

Comments

@cagataycivici
Copy link
Member

Add maximizable property to Dialog to toggle full screen mode.
@cagataycivici cagataycivici self-assigned this Jun 25, 2018
@cagataycivici cagataycivici added the Type: New Feature Issue contains a new feature or new component request label Jun 25, 2018
@cagataycivici cagataycivici added this to the 1.6.3 milestone Jun 25, 2018
@MarioKrstevski
Copy link

I have a question regarding this. When the dialog is maximized, I want to have some control of the rendering logic, mostly regarding to styling. Is there a way to get a prop of isMaximized somehow to handle this?

Right now, the modal just changes a className, which doesn't make a rerender, so I can't get the state if it is maximized even if I use refs or document.getElement api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagataycivici cagataycivici

Labels
Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Milestone
2.0.0-alpha.1
Development

No branches or pull requests
2 participants
@cagataycivici @MarioKrstevski