Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

className parameter unsupported by Spinner component #548

Closed
ghost opened this issue Aug 27, 2018 · 0 comments
Closed

className parameter unsupported by Spinner component #548

ghost opened this issue Aug 27, 2018 · 0 comments
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@ghost
Copy link

ghost commented Aug 27, 2018

There is no guarantee in receiving an immediate response in GitHub Issue Tracker, If you'd like to secure our response, you may consider PrimeReact PRO Support where support is provided within 4 business hours

I'm submitting a ... (check one with "x")

[x] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Plunkr Case (Bug Reports)

https://plnkr.co/edit/qqSX5kifO74fwWrN38QT?p=preview

Current behavior

Inserting a className parameter in a Spinner has no effect on how the Spinner is rendered, and the inserted class name does not appear on the DOM element.

Expected behavior

Inserting a className parameter in a Spinner has an effect on how the Spinner is rendered, and the inserted class name appears on the DOM element.

Minimal reproduction of the problem with instructions

See above Plunker

Please tell us about your environment:

Development in IntelliJ, execution on Webpack Dev Server and Glassfish

  • React version:

16.4.2

  • PrimeReact version:

2.0.0-beta.1

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Tested in Chrome (latest), Firefox (latest) and IE 9

  • Language: [all | TypeScript X.X | ES6/7 | ES5]
    ES6

How to fix
In Spinner.js, on line 391, change
let className = classNames("p-spinner p-component");
to
let className = classNames("p-spinner p-component", this.props.className);

@cagataycivici cagataycivici self-assigned this Aug 28, 2018
@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Aug 28, 2018
@cagataycivici cagataycivici added this to the 2.0.0-beta.4 milestone Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

1 participant