-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calendar: Range selectionMode does not allow multi-year (month?) #6554
Comments
i just tried your reproduce is it possible its fixed with 10.6.5 because it seems to be working now? |
No its still a bug I see your same behavior. |
@KirilCycle i think this bug is related to your fix here: #6478 |
Ill take a look |
@melloware that's weird, I pulled the latest changes, switched to the prod branch and can't reproduce 1 typing issue Screen.Recording.2024-05-03.at.20.46.21.mov |
@KirilCycle try it with the mouse too, when I select a date, then try to advance to the next month to pick another date it auto picks the next date and closes the calendar? |
@melloware I can easily reproduce both of them on the stack, but locally they work fine, I checked the pulled changes twice recently, should I try to run the build? Screen.Recording.2024-05-03.at.20.55.14.mov |
Oh try this... temporarily change in |
Still, cant reproduce, version is 10.6.5 |
it might be a whacky Stackblitz thing. @mgmodell can you try your real project with 10.6.5? |
I just updated in my project and it appears to be resolved in 10.6.5. Thanks! |
Describe the bug
I just upgraded to the latest PrimeReact and tests which used to pass now fail. Specifically, I use the
range
selectionMode on the Calendar component and I want to enter the range: "07/29/1984 - 02/10/1985" but it will not accept it either as text or via popup.Using the text input removes the second date as soon as I enter the '5' in 1985. This seems to happen as soon as any second date is completed.
If I use the popup, as soon as I switch the month, it selects a date in the new month and does not function properly (e.g. when I navigate from July 1984 to August 1984, it selects a date and closes). When I open it to try to repair the issue, it wants to start over with the start date.
The attached Stackblitz is really just a copy of the one found on your page with
readOnlyInput
removed, but you can add it back in and still demonstrate #2.Reproducer
https://stackblitz.com/edit/sunldw?file=src%2FApp.jsx
PrimeReact version
10.6.4
React version
18.x
Language
TypeScript
Build / Runtime
Create React App (CRA)
Browser(s)
Chrome 124.0.6367.119
Steps to reproduce the behavior
Expected behavior
Both dates should be properly accepted and listed in the input box.
The text was updated successfully, but these errors were encountered: