Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent API to add CSS class with certain of your component #68

Closed
Julienng opened this issue Aug 17, 2017 · 1 comment
Closed
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@Julienng
Copy link

I've got a problem with the styleClass properties on some of your components because it doesn't follow the React className.

If I want to add a CSS class to a component like Button I have to do :

<Button className="my-super-class" />

which is great because this is the same for every component with React.

but for the color picker, I have to do :

<ColorPicker styleClass="my-super-class" />

I think every CSS class property for component should follow the className naming to be consistent with the React ecosystem and to simplify the use of your components.

@cagataycivici
Copy link
Member

I agree, we should use className all across, @mertsincan please do the change for beta.5.

@mertsincan mertsincan added this to the 1.0.0-beta.5 milestone Aug 18, 2017
@mertsincan mertsincan added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Aug 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

3 participants