FileUpload: Property objectURL does not exist on type File

[ewenjo]

Describe the bug

Property objectURL does not exist on type File

Reproducer

https://stackblitz.com/edit/vitejs-vite-gc9s8d?file=src%2FApp.tsx

System Information

Blank

Steps to reproduce the behavior

1: Access fileupload files, such as with fileupload.getFiles()
2: Attempt to use file.objectURL property.

Expected behavior

Should be typed as a string

[melloware]

@ewenjo the typing is correct as File which is a JS declaration of File.

/**
     * Gets the current files list.
     * @return {File[]} Current files.
     */
    public getFiles(): File[];

Node.js defines that File object as...

interface File extends _File {}
    var File: typeof globalThis extends {
        onmessage: any;
        File: infer T;
    } ? T
        : typeof import("node:buffer").File;

So it seems like the Node definition is out of date or incorrect.

[ewenjo]

@ewenjo the typing is correct as File which is a JS declaration of File.

/**
     * Gets the current files list.
     * @return {File[]} Current files.
     */
    public getFiles(): File[];

Wouldn't the correct type be?

File & { objectURL?: string }

As the code is conditionally extending the File object with the objectURL property that otherwise doesn't exist in the spec. As shown here:

primereact/components/lib/fileupload/FileUpload.js

Lines 130 to 131 in 513af5e

	file.objectURL = window.URL.createObjectURL(file);

So it seems like the Node definition is out of date or incorrect.

I don't believe objectURL is something that should be defined in the node definition. It's unrelated and doesn't apply to all files.

[melloware]

AHHH i see that is a custom property for use in FileUpload. Yeah it probably should be then... Want to submit a PR?

[ewenjo]

Sure, I might have some time later today

[melloware]

I think File is used in a few places in the fileupload.d.ts file so we may want to declare the type and re-use it in the multiple spots?

[ewenjo]

Yes, that was my thought as well