Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable row selection slow with sortable columns #813

Closed
mertsincan opened this issue Mar 15, 2019 · 0 comments
Closed

DataTable row selection slow with sortable columns #813

mertsincan opened this issue Mar 15, 2019 · 0 comments
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@mertsincan
Copy link
Member

Reported By PRO User;

Hello,

Selecting a row is very slow because DataTable.processData is called on every render which sorts the value every time (https://github.com/primefaces/primereact/blob/master/src/components/datatable/DataTable.js#L1216)

In my opinion it is ok that it is slow when clicking on the column header (actually sorting the table, user expects a small loading time), but not on selecting a row

Test Case:
https://codesandbox.io/s/qzl78j1v9j

@mertsincan mertsincan added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Mar 15, 2019
@mertsincan mertsincan added this to the 3.1.1 milestone Mar 15, 2019
@mertsincan mertsincan self-assigned this Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

1 participant