Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calendar: Invalid TypeScript definitions for modelValue #3400

Closed
Magiczne opened this issue Dec 14, 2022 · 0 comments · Fixed by #3472
Closed

Calendar: Invalid TypeScript definitions for modelValue #3400

Magiczne opened this issue Dec 14, 2022 · 0 comments · Fixed by #3472
Assignees
@tugcekucukoglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
3.22.0

Comments

@Magiczne
Copy link
Contributor

Magiczne commented Dec 14, 2022 •
edited
Loading

Describe the bug

Currently modelValue in types for the calendar is defined with this type:
type CalendarValueType = Date | Date[] | undefined;

But the component supports passing date as string, so it probably should be

type CalendarValueType = string | Date | string[] | Date[] | undefined;

Reproducer

.

PrimeVue version

3.21

Vue version

3.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@Magiczne Magiczne added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 14, 2022
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 14, 2022
@tugcekucukoglu tugcekucukoglu added this to the 3.22.0 milestone Dec 14, 2022
@tugcekucukoglu tugcekucukoglu self-assigned this Dec 14, 2022
This was referenced Jan 1, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
3.22.0
Development

Successfully merging a pull request may close this issue.

Calendar: Invalid TypeScript definitions for modelValue primefaces/primevue
2 participants
@Magiczne @tugcekucukoglu