Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tab Menu: Add role to ink bar #3583

Closed
harrisonwillettbetterworks opened this issue Jan 25, 2023 · 0 comments
Closed

Tab Menu: Add role to ink bar #3583

harrisonwillettbetterworks opened this issue Jan 25, 2023 · 0 comments
Assignees
@mertsincan
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
3.24.0

Comments

@harrisonwillettbetterworks
Copy link

Describe the bug

The Tab Menu component has a WCAG SC 1.3.1 failure found here:

primevue/components/tabmenu/TabMenu.vue

Line 37 in b23b314

<li ref="inkbar" class="p-tabmenu-ink-bar"></li>

When running Axe Dev Tools on any Tab Menu two errors are seen both sighting a failure of SC 1.3.1. By adding the role="presentation" to the inkbar this error should be resolved.

Proposed Fix

<li role="presentation" ref="inkbar" class="p-tabmenu-ink-bar"></li>

PrimeVue version

3.22.4

Vue version

3.x

Language

TypeScript
@mertsincan mertsincan self-assigned this Jan 25, 2023
@mertsincan mertsincan added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Jan 25, 2023
@mertsincan mertsincan added this to the 3.23.0 milestone Jan 25, 2023
@tugcekucukoglu tugcekucukoglu modified the milestones: 3.23.0, 3.24.0 Jan 30, 2023
@mertsincan mertsincan added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Mar 2, 2023
@mertsincan mertsincan changed the title Tab Menu: Issue Title Tab Menu: Add role to ink bar Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mertsincan mertsincan

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
3.24.0
Development

No branches or pull requests
3 participants
@mertsincan @tugcekucukoglu @harrisonwillettbetterworks