Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoComplete: NumpadEnter is not recognised #3816

Closed
oselz opened this issue Mar 28, 2023 · 1 comment
Closed

AutoComplete: NumpadEnter is not recognised #3816

oselz opened this issue Mar 28, 2023 · 1 comment
Assignees
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@oselz
Copy link

oselz commented Mar 28, 2023

Describe the bug

<NumpadEnter> is not recognised by AutoComplete component.

Autocomplete onKeyDown monitors event.code in which there is a difference between <Enter> and <NumpadEnter> and thus cannot be used to select an auto completed item.

Instead onKeyDown should switch against event.key where both Enter keys will result in a Enter event key.

The issue is located here:

Reproducer

https://codesandbox.io/p/sandbox/prod-snow-8msdfd

PrimeVue version

3.26.1

Vue version

3.x

Language

ALL

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

Type 'abc' into the autocomplete and press the Enter key adjacent the number pad on a full size keyboard.

Expected behavior

Highlighted autocomplete item should be selected.

@oselz oselz added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 28, 2023
@oselz oselz changed the title Component Name: Issue Title AutoComplete: <NumpadEnter> is not recognised Mar 28, 2023
@tugcekucukoglu tugcekucukoglu added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add Component: Accessibility Issue or pull request is related to WCAG or ARIA and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 29, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.27.0 milestone Mar 29, 2023
@tugcekucukoglu tugcekucukoglu self-assigned this Mar 29, 2023
@tugcekucukoglu tugcekucukoglu changed the title AutoComplete: <NumpadEnter> is not recognised AutoComplete: NumpadEnter is not recognised Mar 30, 2023
@oselz
Copy link
Author

oselz commented Mar 30, 2023

@tugcekucukoglu Appreciate the quick fix.

FYI, searching the codebase for case: 'Enter': shows a large number of other components have this identical issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

2 participants