Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panel: Wrong prop type in header slot #4086

Closed
Neluji opened this issue Jun 26, 2023 · 0 comments · Fixed by #4087
Closed

Panel: Wrong prop type in header slot #4086

Neluji opened this issue Jun 26, 2023 · 0 comments · Fixed by #4087
Assignees
@tugcekucukoglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
3.30.1

Comments

@Neluji
Copy link
Contributor

Neluji commented Jun 26, 2023 •
edited
Loading

Describe the bug

The id prop of the header slot in the Panel component is typed as boolean, although documentation understandably says that it should be a string :

primevue/components/lib/panel/Panel.d.ts

Lines 145 to 149 in 599faa3

header(scope: {
/**
* Current id state as a string
*/
id: boolean;

Reproducer

https://primevue.org/panel/#api.panel.slots.header

PrimeVue version

3.29.2

Vue version

3.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@Neluji Neluji added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jun 26, 2023
@Neluji Neluji mentioned this issue Jun 26, 2023
Merged
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jul 10, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.31.0 milestone Jul 10, 2023
@tugcekucukoglu tugcekucukoglu self-assigned this Jul 10, 2023
@mertsincan mertsincan modified the milestones: 3.31.0, 3.30.1 Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
3.30.1
Development

Successfully merging a pull request may close this issue.

Fix type of id prop in Panel header slot Neluji/primevue
3 participants
@mertsincan @tugcekucukoglu @Neluji