Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the performance of resolveFieldData method in core #4296

Closed
MoMack20 opened this issue Aug 18, 2023 · 0 comments · Fixed by #4290
Closed

Improve the performance of resolveFieldData method in core #4296

MoMack20 opened this issue Aug 18, 2023 · 0 comments · Fixed by #4290
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
3.34.0

Comments

@MoMack20
Copy link
Contributor

Describe the bug

The resolveFieldData utility currently uses Object.keys as its first check before trying to return data. The call to Object.keys can get quite expensive and result in bad performance. This shows when its called for a large data set for a large number of components.

image

image

Reproducer

https://codesandbox.io/s/primevue-create-vue-issue-template-kw9g6i

PrimeVue version

3.*

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@MoMack20 MoMack20 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 18, 2023
@MoMack20 MoMack20 mentioned this issue Aug 18, 2023
Merged
@melloware melloware mentioned this issue Aug 18, 2023
Closed
@mertsincan mertsincan changed the title resolveFieldData Performance Improvement Improve the performance of resolveFieldData method in core Sep 5, 2023
@mertsincan mertsincan added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 5, 2023
@mertsincan mertsincan added this to the 3.33.1 milestone Sep 5, 2023
@mertsincan mertsincan linked a pull request Sep 5, 2023 that will close this issue
Performance update for resolveFieldData #4290
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
3.34.0
Development

Successfully merging a pull request may close this issue.

Performance update for resolveFieldData MoMack20/primevue-datatable-fix
2 participants
@MoMack20 @mertsincan