Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColorPicker: click on label does not open the color picker #6044

Closed
AnnaYuS opened this issue Jul 10, 2024 · 0 comments · Fixed by #6047
Closed

ColorPicker: click on label does not open the color picker #6044

AnnaYuS opened this issue Jul 10, 2024 · 0 comments · Fixed by #6047
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@AnnaYuS
Copy link

AnnaYuS commented Jul 10, 2024

Describe the bug

It looks like in this case the inputId prop doesn't pass the id to the input element, so clicking on the label doesn't open the color picker. I couldn't find inputId documented anywhere, only in the example. Maybe this prop got removed by accident?

<div class="flex-1 flex flex-column align-items-center">
  <label for="cp-hsb" class="font-bold block mb-2"> HSB </label>
  <ColorPicker v-model="colorHSB" inputId="cp-hsb" format="hsb" class="mb-3" />
  <span>{{ JSON.stringify(colorHSB) }}</span>
</div>

https://stackblitz.com/edit/j2yvfd?file=src%2FApp.vue

Reproducer

https://stackblitz.com/edit/j2yvfd?file=src%2FApp.vue

PrimeVue version

^3.50.0

Vue version

3.x

Language

ALL

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

Go to stackblitz example for ColorPicker https://stackblitz.com/edit/j2yvfd?file=src%2FApp.vue
Try to click the label (HEX, RGB etc)

Expected behavior

Clicking on the label opens the color picker

@AnnaYuS AnnaYuS added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 10, 2024
@tugcekucukoglu tugcekucukoglu added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jul 22, 2024
@tugcekucukoglu tugcekucukoglu modified the milestones: 4.1.0, 4.0.2 Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants