Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuxt plugin types break if I add @primevue/nuxt-module to modules #6289

Closed
frasza opened this issue Aug 25, 2024 · 7 comments
Closed

Nuxt plugin types break if I add @primevue/nuxt-module to modules #6289

frasza opened this issue Aug 25, 2024 · 7 comments
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@frasza
Copy link

frasza commented Aug 25, 2024

Describe the bug

I have axios plugin that provides its instance to the app and in case I add @primevue/nuxt-module to the nuxt config modules array, the plugin type becomes unknown.

Might be same issue as with nuxt/nuxt#28672 -- it was fixed with module-builder hotfix in nuxt-modules/i18n#3071

Reproducer

https://stackblitz.com/edit/github-htegss?file=nuxt.config.ts

PrimeVue version

4.0.5

Vue version

3.x

Language

TypeScript

Build / Runtime

Nuxt

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@frasza frasza added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 25, 2024
@frasza
Copy link
Author

frasza commented Aug 25, 2024

cc: @danielroe

Daniel, sorry for tagging you 🙏 Thought of you jumped on as it seems to be same issue as with i18n module that you PR fixed.

@danielroe
Copy link
Contributor

Yes, the module builder needs to be updated here also.

@tugcekucukoglu tugcekucukoglu removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 29, 2024
@murshex
Copy link

murshex commented Sep 3, 2024

Also breaking my functions from ./utils

@murshex
Copy link

murshex commented Sep 3, 2024

This makes my functions from ./utils unable to be used in templates. But I can still use the functions from ./utils in scripts

@danielroe
Copy link
Contributor

danielroe commented Sep 4, 2024

I've created #6336, but note that we also need #6207

@mertsincan
Copy link
Member

Thanks a lot, @danielroe ;)

@mertsincan mertsincan added this to the 4.0.6 milestone Sep 4, 2024
@mertsincan mertsincan added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Sep 4, 2024
@tugcekucukoglu tugcekucukoglu modified the milestones: 4.0.6, 4.0.7, 4.1.0 Sep 10, 2024
@m61x
Copy link

m61x commented Sep 12, 2024

This issue can be closed as it was resolved with the release of version 4.0.6. Both #6336 and #6207 were merged into the main branch prior to the release. Therefore, @tugcekucukoglu does not need to adjust the milestones for this issue.

@frasza frasza closed this as completed Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

7 participants
@mertsincan @frasza @danielroe @murshex @tugcekucukoglu @m61x and others