Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToggleButton: aria-label and aria-labelledby not observed #6377

Closed
jacobtylerwalls opened this issue Sep 10, 2024 · 1 comment
Closed

ToggleButton: aria-label and aria-labelledby not observed #6377

jacobtylerwalls opened this issue Sep 10, 2024 · 1 comment
Assignees
@tugcekucukoglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
4.0.7

Comments

@jacobtylerwalls
Copy link
Contributor

jacobtylerwalls commented Sep 10, 2024 •
edited
Loading

Describe the bug

ToggleButton is documented to take aria-label and aria-labelledby props, but nothing is done with them.

Reproducer

https://stackblitz.com/edit/missing-aria-label?file=src%2FApp.vue

PrimeVue version

4.0.1

Vue version

4.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@jacobtylerwalls jacobtylerwalls added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 10, 2024
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 11, 2024
@tugcekucukoglu tugcekucukoglu added this to the 4.0.7 milestone Sep 11, 2024
@tugcekucukoglu tugcekucukoglu self-assigned this Sep 11, 2024
@fafeitsch
Copy link

Hey, thanks for the fast fix in 4.0.7. The attribute arial-abelledby does now work.

However, the aria-label still does not work like the documentation (https://primevue.org/togglebutton/#accessibility) says it should, it's still ignored. Your commit seems to have removed the aria-label completely from the ToggleButton.

What was the rationale of removing the support for aria-label for the ToggleButton?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
4.0.7
Development

No branches or pull requests
3 participants
@fafeitsch @tugcekucukoglu @jacobtylerwalls