Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [BUG] - RiverStoryScroll incorrectly applies a negative margin when disabled #734

Open
rezrah opened this issue Sep 5, 2024 · 0 comments
Open

🐛 [BUG] - RiverStoryScroll incorrectly applies a negative margin when disabled #734

rezrah opened this issue Sep 5, 2024 · 0 comments
Labels
brand bug Something isn't working

Comments

@rezrah
Copy link
Collaborator

rezrah commented Sep 5, 2024

Describe the bug

RiverStoryScroll applies a negative margin of -20vh to enable the animation effect. When animations are disabled through the disabled prop however, there is no need to apply the relevant CSS.

Reproduction steps

  1. Add disabled prop to the RiverStoryScroll component, ideally with content that appears before it
  2. Observe the effect is disabled
  3. Observe the CSS of margin-top: -2vh has been applied
  4. If tested with preceding content, the RiverStoryScroll will overlap with that content

Expected behavior

The negative margin should only apply when the disabled flag is false.

Screenshots

RiverStoryScroll with disabled flag and negative margin styles applied. Causing Rivers to overlap with preceding content.

Browsers

No response

OS

No response
@rezrah rezrah added brand bug Something isn't working labels Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
brand bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rezrah