Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate SideNav to TypeScript #1040

Merged
merged 5 commits into from
Feb 10, 2021
Merged

Migrate SideNav to TypeScript #1040

merged 5 commits into from
Feb 10, 2021

Conversation

VanAnderson
Copy link
Contributor

This PR migrates the SideNav component to TypeScript as part of the TypeScript refactor.

@vercel
Copy link

vercel bot commented Feb 9, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/5rfpt2tyd
✅ Preview: https://primer-components-git-vananderson-sidenav-tsx-migration.primer.now.sh

@changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: 07bb1fc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel vercel bot temporarily deployed to Preview February 9, 2021 20:36 Inactive
VanAnderson
VanAnderson commented Feb 9, 2021
View reviewed changes
src/SideNav.tsx
type StyledSideNavBaseProps = {
variant?: 'lightweight' | 'normal'
bordered?: boolean
} & ComponentProps<typeof BorderBox>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This felt slightly different from the nested pattern we have just recently used since we are starting with an existing component here - tried to fall in line with the other patterns we had for starting with an existing component.

@VanAnderson VanAnderson marked this pull request as ready for review February 9, 2021 20:40
@VanAnderson VanAnderson mentioned this pull request Feb 9, 2021
Closed
53 tasks
colebemis
colebemis approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just left a couple suggestions

src/SideNav.tsx Outdated Show resolved Hide resolved
src/SideNav.tsx Outdated Show resolved Hide resolved
src/SideNav.tsx Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview February 10, 2021 19:26 Inactive
@VanAnderson @colebemis
Revisions to SideNav component migration
8746959 
Co-authored-by: Cole Bemis <colebemis@github.com>
@VanAnderson VanAnderson force-pushed the VanAnderson/SideNav-TSX-migration branch from 3b70548 to 8746959 Compare February 10, 2021 19:32
@vercel vercel bot temporarily deployed to Preview February 10, 2021 19:32 Inactive
@vercel vercel bot temporarily deployed to Preview February 10, 2021 21:19 Inactive
@colebemis colebemis merged commit b8b60e7 into main Feb 10, 2021
@colebemis colebemis deleted the VanAnderson/SideNav-TSX-migration branch February 10, 2021 21:23
@github-actions github-actions bot mentioned this pull request Feb 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colebemis colebemis colebemis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VanAnderson @colebemis