Skip to content

Commit 2eabfde

Browse files
stamatlangermank
andauthored
[a11y] Removing !important from letter-spacing marketing typography (#2613)
* removing !important from letter-spacing marketing typography * Create proud-rockets-kiss.md --------- Co-authored-by: Katie Langerman <18661030+langermank@users.noreply.github.com>
1 parent c5bf346 commit 2eabfde

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

.changeset/proud-rockets-kiss.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@primer/css": patch
3+
---
4+
5+
removing !important from letter-spacing marketing typography

src/marketing/type/typography.scss

+6-6
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
font-feature-settings: $mktg-font-feature-settings;
1111
// stylelint-disable-next-line primer/typography
1212
font-weight: $mktg-header-weight-default !important;
13-
letter-spacing: $mktg-header-spacing-default !important;
13+
letter-spacing: $mktg-header-spacing-default;
1414
}
1515

1616
@each $header, $sizes in $mktg-headers {
@@ -30,7 +30,7 @@
3030
line-height: map-get($pairing-md, 'lh') !important;
3131

3232
@if (map-get($pairing-md, 'size') >= $mktg-header-spacing-threshold and map-get($pairing, 'size') < $mktg-header-spacing-threshold) {
33-
letter-spacing: $mktg-header-spacing-large !important;
33+
letter-spacing: $mktg-header-spacing-large;
3434
}
3535

3636
@if (map-get($pairing-md, 'size') >= $mktg-header-weight-threshold and map-get($pairing, 'size') < $mktg-header-weight-threshold) {
@@ -45,7 +45,7 @@
4545
line-height: map-get($pairing-lg, 'lh') !important;
4646

4747
@if (map-get($pairing-lg, 'size') >= $mktg-header-spacing-threshold and map-get($pairing-md, 'size') < $mktg-header-spacing-threshold) {
48-
letter-spacing: $mktg-header-spacing-large !important;
48+
letter-spacing: $mktg-header-spacing-large;
4949
}
5050

5151
@if (map-get($pairing-lg, 'size') >= $mktg-header-weight-threshold and map-get($pairing-md, 'size') < $mktg-header-weight-threshold) {
@@ -77,7 +77,7 @@
7777
font-size: map-get($pairing, 'size') !important;
7878
line-height: map-get($pairing, 'lh') !important;
7979

80-
@if (map-get($pairing, 'size') >= $mktg-body-spacing-threshold) { letter-spacing: $mktg-body-spacing-large !important; }
80+
@if (map-get($pairing, 'size') >= $mktg-body-spacing-threshold) { letter-spacing: $mktg-body-spacing-large; }
8181

8282
@if (map-get($pairing, 'size') >= $mktg-body-weight-threshold) { font-weight: $font-weight-semibold; }
8383

@@ -87,7 +87,7 @@
8787
line-height: map-get($pairing-md, 'lh') !important;
8888

8989
@if (map-get($pairing-md, 'size') >= $mktg-body-spacing-threshold and map-get($pairing, 'size') < $mktg-body-spacing-threshold) {
90-
letter-spacing: $mktg-body-spacing-large !important;
90+
letter-spacing: $mktg-body-spacing-large;
9191
}
9292

9393
@if (map-get($pairing-md, 'size') >= $mktg-body-weight-threshold and map-get($pairing, 'size') < $mktg-body-weight-threshold) {
@@ -102,7 +102,7 @@
102102
line-height: map-get($pairing-lg, 'lh') !important;
103103

104104
@if (map-get($pairing-lg, 'size') >= $mktg-body-spacing-threshold and map-get($pairing-md, 'size') < $mktg-body-spacing-threshold) {
105-
letter-spacing: $mktg-body-spacing-large !important;
105+
letter-spacing: $mktg-body-spacing-large;
106106
}
107107

108108
@if (map-get($pairing-lg, 'size') >= $mktg-body-weight-threshold and map-get($pairing-md, 'size') < $mktg-body-weight-threshold) {

0 commit comments

Comments
 (0)