btn-link has background gradient

[JasonEtco]

Hey folks!

Running into an overlap of styles: btn-link sets the background-color to transparent, but its background-image still inherits a background gradient image. I can fix this in a PR if you'd like, should just be to add background-image: none to the .btn-link class 👍

<button class="btn btn-link">Hello Button</button>

[broccolini]

👋 Hi @JasonEtco

Well spotted. I did a little digging in github/github and looks like btn-link is mostly being used on it's own without the btn. But I'd absolutely expect people to think it should be used with btn since that's the pattern for using every other button!

I'd welcome a pr to fix the gradient issue, making this update won't impact how we use it in github/github so this is a low risk update for us to include. I think this should also include resetting the font-weight to normal with $font-weight-normal because the intended purpose of btn-link is to style a button like a regular link with doesn't have a bold font-weight.

You may have seen we've started using storybook and there isn't a story for btn-link's yet, nor is it documented, so if you're game, adding a story and example in the docs would be rad additions too!

We're working on v10 and aiming to get that ready to ship by end of next week, so if you have time to work on this soon we can add this update to that release.

[JasonEtco]

@broccolini that all makes sense; I'll make that PR asap!

side note: Last night I started on a React-Primer implementation using Storybook for some some personal projects (and some Probot stuff), so imagine my delight when I checked out the repo for the first time in awhile and saw .storybook/! Definitely going to give that a look through.

[broccolini]

Last night I started on a React-Primer implementation using Storybook for some some personal projects (and some Probot stuff), so imagine my delight when I checked out the repo for the first time in awhile and saw .storybook/! Definitely going to give that a look through.

Awesome! Excited to see what you make! Also, watch this space for more along those lines 😎

[JasonEtco]

Going to close this out since PR #382 was merged, and contains a description of what went down regarding the .btn-link class (doc changes, not CSS changes). Thanks 🎉 🌮