Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing text-underline class #540

Closed
dmalan opened this issue Jul 9, 2018 · 2 comments
Closed

missing text-underline class #540

dmalan opened this issue Jul 9, 2018 · 2 comments

Comments

@dmalan
Copy link

dmalan commented Jul 9, 2018

Is your feature request related to a problem? Please describe.

Per https://styleguide.github.com/primer/utilities/typography/#typographic-styles, primer-core has a fairly exhaustive list of utility classes for typographic styles, including no-underline, but lacks a corresponding text-underline.

Describe the solution you'd like

In primer-utilities/lib/typography.scss, which currently contains

.no-underline { text-decoration: none !important; }

perhaps a corresponding

.text-underline { text-decoration: underline !important; }

for completeness?

Describe alternatives you've considered

Custom CSS!

@pqt
Copy link
Contributor

pqt commented Jul 28, 2018

Not sure why, but this was merged (and referenced the issue). It's on master now, so this issue can be closed, I thought it would be automatically 🤔 @dmalan, thanks for bringing it up!

@dmalan
Copy link
Author

dmalan commented Jul 28, 2018

Thanks, @austinpaquette!

@dmalan dmalan closed this as completed Jul 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants