You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We've got issues updating Primer in github/github with also having to update the version of stylelint-config-primer because the common version of primer-utilities must match exactly in order for that package to be "hoisted" to the top-level node_modules directory. (In other words, if you don't update stylelint-config-primer when you're updating primer, you end up with separate versions of primer-utilities in each of the dependent package's own node_modules directories.)
One way to do this is to make primer-utilities a dev dependency and "bake" the utility classes into the library at build/publish time.
Another is to loosen the primer-utilities version specifier so that npm can hoist the specific version from primer.
shawnbot
changed the title
primer-utilities has a runtime dependency on stylelint-config-primer
stylelint selector-no-utiltiy has a runtime primer-utilities dependency
Nov 8, 2018
shawnbot
changed the title
stylelint selector-no-utiltiy has a runtime primer-utilities dependency
stylelint selector-no-utility has a runtime primer-utilities dependency
Nov 8, 2018
We've got issues updating Primer in github/github with also having to update the version of
stylelint-config-primer
because the common version ofprimer-utilities
must match exactly in order for that package to be "hoisted" to the top-levelnode_modules
directory. (In other words, if you don't updatestylelint-config-primer
when you're updatingprimer
, you end up with separate versions ofprimer-utilities
in each of the dependent package's ownnode_modules
directories.)One way to do this is to make
primer-utilities
a dev dependency and "bake" the utility classes into the library at build/publish time.Another is to loosen the
primer-utilities
version specifier so that npm can hoist the specific version fromprimer
.@emplums @jonrohan, any thoughts, preferences?
The text was updated successfully, but these errors were encountered: