Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylelint selector-no-utility has a runtime primer-utilities dependency #592

Closed
shawnbot opened this issue Oct 24, 2018 · 1 comment
Closed
Assignees

Comments

@shawnbot
Copy link
Contributor

We've got issues updating Primer in github/github with also having to update the version of stylelint-config-primer because the common version of primer-utilities must match exactly in order for that package to be "hoisted" to the top-level node_modules directory. (In other words, if you don't update stylelint-config-primer when you're updating primer, you end up with separate versions of primer-utilities in each of the dependent package's own node_modules directories.)

One way to do this is to make primer-utilities a dev dependency and "bake" the utility classes into the library at build/publish time.

Another is to loosen the primer-utilities version specifier so that npm can hoist the specific version from primer.

@emplums @jonrohan, any thoughts, preferences?

@shawnbot shawnbot changed the title primer-utilities has a runtime dependency on stylelint-config-primer stylelint selector-no-utiltiy has a runtime primer-utilities dependency Nov 8, 2018
@shawnbot shawnbot self-assigned this Nov 8, 2018
@shawnbot shawnbot changed the title stylelint selector-no-utiltiy has a runtime primer-utilities dependency stylelint selector-no-utility has a runtime primer-utilities dependency Nov 8, 2018
@shawnbot
Copy link
Contributor Author

Fixed in #597!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant