Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box-header has double borders #685

Closed
shawnbot opened this issue Feb 20, 2019 · 0 comments
Closed

Box-header has double borders #685

shawnbot opened this issue Feb 20, 2019 · 0 comments
Assignees

Comments

@shawnbot
Copy link
Contributor

Box headers (.Box .Box-header) have a double border on their sides:

image

I discovered this on github.com, confirmed that it's not an issue in primer@11.0.0, and compared the @primer/css CSS build with the primer@11.0.0 CSS build to confirm that it's a regression. It turns out that this seeming innocuous commit is the root of the problem. Before:

margin: -1px -1px 0 -1px;

after:

margin: -$border-width -$border-width 0;

I assumed that this would be interpreted as -1px -1px 0, but it looks like the - are being treated as mathematical operators and we're getting -2px 0 in the output. I think the fix is to wrap the numbers in parens, which is something that we do elsewhere in the same file:

.Box-header {
  // ...
  margin: (-$border-width) (-$border-width) 0;
  // ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant