Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New border fade utilities are overridden by directional border utilities. #726

Closed
jonrohan opened this issue Mar 14, 2019 · 1 comment
Closed
Assignees

Comments

@jonrohan
Copy link
Member

Describe the bug
The new border fade utilities #713 don't change the colors of the border when used with directional border utilities.

To Reproduce

Works as expected like this:

<div class="border border-white-fade-15">This works</div>

Doesn't work like this:

<div class="border-top border-white-fade-15">This doesn't work</div>

Additional context

I think we need to move the border color utilities below this section of directional breakpoint border utilities https://github.com/primer/css/blob/master/src/utilities/borders.scss#L59-L108

@simurai
Copy link
Contributor

simurai commented Mar 14, 2019

I think we need to move the border color utilities below this section of directional breakpoint border utilities https://github.com/primer/css/blob/master/src/utilities/borders.scss#L59-L108

👍 Moved the colors down in #727

In the meantime you could remove all sides except the top:

<div class="border border-white-fade-15 border-left-0 border-right-0 border-bottom-0">

But yeah, it's a bit lengthy.

@simurai simurai closed this as completed May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants