Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove primer/deploy action #809

Merged
merged 1 commit into from
May 22, 2019
Merged

Remove primer/deploy action #809

merged 1 commit into from
May 22, 2019

Conversation

shawnbot
Copy link
Contributor

This removes the primer/deploy action in favor of using Now's GitHub integration, which has some distinct advantages:

  1. It uses the GitHub Deployments API, so the deployment links aren't buried in commit statuses.

  2. It handles canceling in-progress builds if you push before they're done:

    With each new push, if Now is already building a previous commit, Now will cancel that current build to start the most recent commit so that you always have the latest changes deployed as quickly as possible.

  3. It apparently creates automatic staging aliases for each pull request. I'm curious to see if this PR gets one, because Select Menu component #808 didn't. 🤔

Let's see how this goes!

@vercel
Copy link

vercel bot commented May 22, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@shawnbot
Copy link
Contributor Author

shawnbot commented May 22, 2019

Re: the staging alias, the docs suggest that staging deployments will be automatically aliased using the following pattern:

But this URL doesn't seem to work:

primer-css-git-now-integration.primer.now.sh

➡️ Spectrum thread re: alias URLs

@shawnbot
Copy link
Contributor Author

Confirmed:

The target aliasing is a Now 2.0 feature, unfortunately.
Are you sure you can't bump your repository to Now 2.0? Do you need any assistance?

If only it were that simple! 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant