Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primer's CSS Guidelines suggests using // for comments #88

Closed
RobLoach opened this issue Apr 1, 2015 · 2 comments · Fixed by #89
Closed

Primer's CSS Guidelines suggests using // for comments #88

RobLoach opened this issue Apr 1, 2015 · 2 comments · Fixed by #89

Comments

@RobLoach
Copy link
Contributor

RobLoach commented Apr 1, 2015

https://github.com/primer/primer/blob/master/docs/guidelines.md#formatting

Use // for comment blocks (instead of /* */).

Without a preprocessor, C-style // comments are invalid.

body {
  background-color: red;
}
// This is an invalid comment.

/* This is a valid comment. */
@RobLoach RobLoach changed the title CSS Guidelines suggests using // for comments Primer's CSS Guidelines suggests using // for comments Apr 1, 2015
@jonrohan
Copy link
Member

jonrohan commented Apr 1, 2015

Thanks for the note, our "css" guidelines are meant to refer to scss files. I'm updating the section title to make it more clear #89

@jonrohan jonrohan added the docs label Apr 1, 2015
@RobLoach
Copy link
Contributor Author

RobLoach commented Apr 1, 2015

Thanks @jonrohan, I assumed as such. Just seemed strange to suggest that CSS use //. 👍

@RobLoach RobLoach closed this as completed Apr 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants